[webkit-reviews] review requested: [Bug 122015] [ATK] Expose aria-invalid as a text attribute (not object attribute) : [Attachment 212974] Patch proposal

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Sep 30 03:37:59 PDT 2013


Mario Sanchez Prada <mario at webkit.org> has asked  for review:
Bug 122015: [ATK] Expose aria-invalid as a text attribute (not object
attribute)
https://bugs.webkit.org/show_bug.cgi?id=122015

Attachment 212974: Patch proposal
https://bugs.webkit.org/attachment.cgi?id=212974&action=review

------- Additional Comments from Mario Sanchez Prada <mario at webkit.org>
Attaching a new patch addressing the issues pointed out by Chris.

Also, considering now that I'd be adding some constants in
AccessibilityUIElementAtk.cpp, I made the most of this patch to move all the
static functions there into unnammed namespaces together with those newly
defined constants.


More information about the webkit-reviews mailing list