[webkit-reviews] review granted: [Bug 122082] Pass VM instead of JSGlobalObject to function constructors. : [Attachment 212943] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Andreas Kling <akling at apple.com>'s
request for review:
Bug 122082: Pass VM instead of JSGlobalObject to function constructors.
https://bugs.webkit.org/show_bug.cgi?id=122082

Attachment 212943: Patch
https://bugs.webkit.org/attachment.cgi?id=212943&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=212943&action=review


> Source/JavaScriptCore/API/JSCallbackObjectFunctions.h:601
>			   

Why keep this blank line?

> Source/JavaScriptCore/API/JSCallbackObjectFunctions.h:604
> +			   VM& vm = exec->vm();
> +			   JSObject* o = JSCallbackFunction::create(vm,
thisObj->globalObject(), callAsFunction, name);
> +			   thisObj->putDirect(vm, propertyName, o,
entry->attributes);

Do local variables pay back in cases like this?