[webkit-reviews] review granted: [Bug 122080] Get rid of static map for marking ancestor line boxes dirty : [Attachment 212937] patch

[bugzilla-daemon at webkit.org]

Andreas Kling <akling at apple.com> has granted Antti Koivisto <koivisto at iki.fi>'s
request for review:
Bug 122080: Get rid of static map for marking ancestor line boxes dirty
https://bugs.webkit.org/show_bug.cgi?id=122080

Attachment 212937: patch
https://bugs.webkit.org/attachment.cgi?id=212937&action=review

------- Additional Comments from Andreas Kling <akling at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=212937&action=review


r=me

> Source/WebCore/rendering/RenderElement.h:132
> +    bool m_ancestorLineBoxDirty : 1;

Now would be a good time to add a compile-time assertion for
sizeof(RenderElement)!

> Source/WebCore/rendering/RenderLineBoxList.h:67
> +    void dirtyLinesFromChangedChild(RenderBlockFlow* parent, RenderObject*
child);

'parent' could be a RenderBlockFlow& here. NABD.