[webkit-reviews] review granted: [Bug 122070] Regression: :after content can fail to repaint borders : [Attachment 212913] Patch

[bugzilla-daemon at webkit.org]

Andreas Kling <akling at apple.com> has granted Philip Rogers <pdr at google.com>'s
request for review:
Bug 122070: Regression: :after content can fail to repaint borders
https://bugs.webkit.org/show_bug.cgi?id=122070

Attachment 212913: Patch
https://bugs.webkit.org/attachment.cgi?id=212913&action=review

------- Additional Comments from Andreas Kling <akling at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=212913&action=review


r=me, great find!

> Source/WebCore/rendering/RenderElement.cpp:300
> -    return diff == StyleDifferenceRepaint || (diff ==
StyleDifferenceRepaintIfText && hasImmediateNonWhitespaceTextChild());
> +    return diff == StyleDifferenceRepaint || (diff ==
StyleDifferenceRepaintIfText &&
hasImmediateNonWhitespaceTextChildOrBorderOrOutline());

The name StyleDifferenceRepaintIfText is no longer entirely accurate.
StyleDifferenceRepaintIfTextOrBorderOrOutline? :|