[webkit-reviews] review granted: [Bug 121020] Crash on shape-outside when using calc() : [Attachment 212834] Patch

[bugzilla-daemon at webkit.org]

Dirk Schulze <krit at webkit.org> has granted Hans Muller
<giles_joplin at yahoo.com>'s request for review:
Bug 121020: Crash on shape-outside when using calc()
https://bugs.webkit.org/show_bug.cgi?id=121020

Attachment 212834: Patch
https://bugs.webkit.org/attachment.cgi?id=212834&action=review

------- Additional Comments from Dirk Schulze <krit at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=212834&action=review


Great patch. Just a snippet. r+

> Source/WebCore/css/CSSCalculationValue.cpp:746
> +	   // FIXME: Create a CSSCalcExpressionNode equivalent of
CalcExpressionBlendLength.

If this bug does not exist yet, please create it and add the link in the
comment.