[webkit-reviews] review denied: [Bug 122005] Removing noisy compilation warnings after r156341 : [Attachment 212787] Patch

[bugzilla-daemon at webkit.org]

Anders Carlsson <andersca at apple.com> has denied Thiago de Barros Lacerda
<thiago.lacerda at openbossa.org>'s request for review:
Bug 122005: Removing noisy compilation warnings after r156341
https://bugs.webkit.org/show_bug.cgi?id=122005

Attachment 212787: Patch
https://bugs.webkit.org/attachment.cgi?id=212787&action=review

------- Additional Comments from Anders Carlsson <andersca at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=212787&action=review


> Source/WebKit2/Platform/CoreIPC/Arguments.h:59
>  
>  template<typename... Elements>
>  struct TupleCoder<0, Elements...> {
> -    static void encode(ArgumentEncoder& encoder, const
std::tuple<Elements...>& tuple)
> +    static void encode(ArgumentEncoder&, const std::tuple<Elements...>&)
>      {
>      }
>  
> -    static bool decode(ArgumentDecoder& decoder, std::tuple<Elements...>&
tuple)
> +    static bool decode(ArgumentDecoder&, std::tuple<Elements...>&)
>      {
>	   return true;
>      }

This was landed in a separate patch.

> Source/WebKit2/WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:1290
> +#if !ENABLE(NETSCAPE_PLUGIN_API)
> +    UNUSED_PARAM(pluginElement);
> +#endif

I prefer having the code be:

#if ENABLE
#else
#endif

Same goes for all the !ENABLE #ifs.