[webkit-reviews] review granted: [Bug 121121] Web Inspector: Make WebKitGTK+ port work with Eclipse chromedevtools plugin : [Attachment 211586] Updated patch against upstream master

[bugzilla-daemon at webkit.org]

Gustavo Noronha (kov) <gns at gnome.org> has granted Andre Moreira Magalhaes
<andrunko at gmail.com>'s request for review:
Bug 121121: Web Inspector: Make WebKitGTK+ port work with Eclipse
chromedevtools plugin
https://bugs.webkit.org/show_bug.cgi?id=121121

Attachment 211586: Updated patch against upstream master
https://bugs.webkit.org/attachment.cgi?id=211586&action=review

------- Additional Comments from Gustavo Noronha (kov) <gns at gnome.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=211586&action=review


> Source/WebKit2/ChangeLog:12
> +	   fails.

s/fails/fail/

> Source/WebKit2/ChangeLog:28
> +	   This patch fix the issues by adding support for the missing fields
and accepting requests

s/fix/fixes/

> Source/WebKit2/UIProcess/InspectorServer/gtk/WebInspectorServerGtk.cpp:128
> +
> +    // chromedevtools (http://code.google.com/p/chromedevtools) 0.3.8
expected JSON format:
> +    // {
> +    //  "title": "Foo",
> +    //  "url": "http://foo",
> +    //  "devtoolsFrontendUrl":
"/Main.html?ws=localhost:9222/devtools/page/1",
> +    //  "webSocketDebuggerUrl": "ws://localhost:9222/devtools/page/1"
> +    // },
> +

This comment might be more useful if it comes before the response is built.