[webkit-reviews] review granted: [Bug 121936] Move m_style to RenderElement : [Attachment 212776] patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Sep 26 18:14:12 PDT 2013


Andreas Kling <akling at apple.com> has granted Antti Koivisto <koivisto at iki.fi>'s
request for review:
Bug 121936: Move m_style to RenderElement
https://bugs.webkit.org/show_bug.cgi?id=121936

Attachment 212776: patch
https://bugs.webkit.org/attachment.cgi?id=212776&action=review

------- Additional Comments from Andreas Kling <akling at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=212776&action=review


This looks great to me!

> Source/WebCore/ChangeLog:66
> +	       Change assert. This can get legitimely called during layout for
first letter renderers.

Typo, legitimately

> LayoutTests/ChangeLog:8
> +	   Progressions from text style updating correctly in all cases.

I'm gonna take your word for this.


More information about the webkit-reviews mailing list