[webkit-reviews] review denied: [Bug 121999] [GCC] Fix build with gcc < 4.8.1, which does not have is_trivially_destructible : [Attachment 212775] Patch

[bugzilla-daemon at webkit.org]

Benjamin Poulain <benjamin at webkit.org> has denied Gustavo Noronha (kov)
<gns at gnome.org>'s request for review:
Bug 121999: [GCC] Fix build with gcc < 4.8.1, which does not have
is_trivially_destructible
https://bugs.webkit.org/show_bug.cgi?id=121999

Attachment 212775: Patch
https://bugs.webkit.org/attachment.cgi?id=212775&action=review

------- Additional Comments from Benjamin Poulain <benjamin at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=212775&action=review


> Source/WTF/wtf/StdLibExtras.h:308
> +#if (defined(_MSC_VER) && _MSC_VER < 1700) || (COMPILER(GCC) && !(__GNUC__
>= 4 && __GNUC_MINOR__ >= 8 && __GNUC_PATCHLEVEL__ >= 1))

Ins't that reimplementing GCC_VERSION_AT_LEAST?

I am pretty sure Clang also matches COMPILER(GCC).

> Source/WTF/wtf/StdLibExtras.h:310
>  // Work-around for Pre-C++11 syntax in MSVC 2010 and prior

You need to fix the comment as well.