[webkit-reviews] review granted: [Bug 121752] [Nix] Updating Nix trunk files : [Attachment 212288] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Sep 26 16:57:41 PDT 2013


Benjamin Poulain <benjamin at webkit.org> has granted Thiago de Barros Lacerda
<thiago.lacerda at openbossa.org>'s request for review:
Bug 121752: [Nix] Updating Nix trunk files
https://bugs.webkit.org/show_bug.cgi?id=121752

Attachment 212288: Patch
https://bugs.webkit.org/attachment.cgi?id=212288&action=review

------- Additional Comments from Benjamin Poulain <benjamin at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=212288&action=review


> Source/WebCore/platform/DragImage.h:44
> +#elif PLATFORM(GTK) || PLATFORM(NIX)

Would it be possible to replace this by a #ifdef depending on Cairo?

> Source/WebCore/platform/DragImage.h:64
>  #elif PLATFORM(EFL) || PLATFORM(BLACKBERRY) || PLATFORM(NIX)

There is a PLATFORM(NIX) here which would never match anything.


More information about the webkit-reviews mailing list