[webkit-reviews] review denied: [Bug 121886] Sync toWebKitCSSShaderValue() behavior with other toCSSFooValue() : [Attachment 212677] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Sep 26 06:54:11 PDT 2013


Ryosuke Niwa <rniwa at webkit.org> has denied Gyuyoung Kim
<gyuyoung.kim at samsung.com>'s request for review:
Bug 121886: Sync toWebKitCSSShaderValue() behavior with other toCSSFooValue()
https://bugs.webkit.org/show_bug.cgi?id=121886

Attachment 212677: Patch
https://bugs.webkit.org/attachment.cgi?id=212677&action=review

------- Additional Comments from Ryosuke Niwa <rniwa at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=212677&action=review


> Source/WebCore/css/StyleResolver.cpp:3626
> +    if (!shadersList->itemWithoutBoundsCheck(0)->isWebKitCSSShaderValue())

Exiting early here changes the behavior


More information about the webkit-reviews mailing list