[webkit-reviews] review requested: [Bug 121749] Move DFG inline caching logic into jit/ : [Attachment 212665] patch 5: one more Windows build fix.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Sep 25 22:41:47 PDT 2013


Mark Lam <mark.lam at apple.com> has asked  for review:
Bug 121749: Move DFG inline caching logic into jit/
https://bugs.webkit.org/show_bug.cgi?id=121749

Attachment 212665: patch 5: one more Windows build fix.
https://bugs.webkit.org/attachment.cgi?id=212665&action=review

------- Additional Comments from Mark Lam <mark.lam at apple.com>
Patch 5 builds jsc properly although I encountered other build issues in
WebCore that are unrelated to this patch.  That said, I think this patch should
be reviewed before I land it.  The changes that I made in addition to the
original patch from http://trac.webkit.org/changeset/156235 are:

1. Rebase up to the latest svn revision.
2. Added FUNCTION_WRAPPER_WITH_RETURN_ADDRESS macros for COMPILER(MSVC) &&
CPU(X86).
3. Moved implementations of getHostCallReturnValue and
getHostCallReturnValueWithExecState to JITOperations.cpp from
DFGOperations.cpp.  These pieces of code needs to be built even if the DFG is
not enabled for build.	Hence, they don't belong in DFGOperations.cpp.
4. I added an implementation of getHostCallReturnValue for COMPILER(MSVC) &&
CPU(X86).


More information about the webkit-reviews mailing list