[webkit-reviews] review granted: [Bug 121933] Do not reenter Document from its destructor : [Attachment 212648] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Sep 25 18:57:35 PDT 2013
Darin Adler <darin at apple.com> has granted Benjamin Poulain
<benjamin at webkit.org>'s request for review:
Bug 121933: Do not reenter Document from its destructor
https://bugs.webkit.org/show_bug.cgi?id=121933
Attachment 212648: Patch
https://bugs.webkit.org/attachment.cgi?id=212648&action=review
------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=212648&action=review
No regression test?
> Source/WebCore/css/CSSStyleSheet.h:114
> + void detachFromDocument() { m_ownerNode = 0; }
nullptr
> Source/WebCore/dom/DocumentStyleSheetCollection.cpp:505
> }
>
> +
> +void DocumentStyleSheetCollection::detachFromDocument()
Looks like there is an extra blank line here.
More information about the webkit-reviews
mailing list