[webkit-reviews] review requested: [Bug 121834] [WIN] Add missing USE(CFNETWORK) to WebError.h : [Attachment 212450] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Sep 25 11:57:44 PDT 2013
Patrick R. Gansterer <paroga at paroga.com> has asked for review:
Bug 121834: [WIN] Add missing USE(CFNETWORK) to WebError.h
https://bugs.webkit.org/show_bug.cgi?id=121834
Attachment 212450: Patch
https://bugs.webkit.org/attachment.cgi?id=212450&action=review
------- Additional Comments from Patrick R. Gansterer <paroga at paroga.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=212450&action=review
>> Source/WebKit/win/WebError.h:93
>> +#if USE(CFNETWORK)
>
> This should be USE(CF), as it's a CFDictionaryRef we are trying to protect
against.
But it's only used by CFNETWORK code. See
http://trac.webkit.org/browser/trunk/Source/WebKit/win/WebError.cpp?rev=149716#
L218
More information about the webkit-reviews
mailing list