[webkit-reviews] review denied: [Bug 121834] [WIN] Add missing USE(CFNETWORK) to WebError.h : [Attachment 212450] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Sep 25 11:44:43 PDT 2013


Brent Fulgham <bfulgham at webkit.org> has denied Patrick R. Gansterer
<paroga at paroga.com>'s request for review:
Bug 121834: [WIN] Add missing USE(CFNETWORK) to WebError.h
https://bugs.webkit.org/show_bug.cgi?id=121834

Attachment 212450: Patch
https://bugs.webkit.org/attachment.cgi?id=212450&action=review

------- Additional Comments from Brent Fulgham <bfulgham at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=212450&action=review


This should be USE(CF), as it's a CFDictionaryRef we are trying to protect
against.

> Source/WebKit/win/WebError.h:93
> +#if USE(CFNETWORK)

This should be USE(CF), as it's a CFDictionaryRef we are trying to protect
against.


More information about the webkit-reviews mailing list