[webkit-reviews] review granted: [Bug 121599] [WIN] Replace CF time functions with Windows API functions in WebHistory : [Attachment 212439] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Sep 25 11:33:10 PDT 2013


Brent Fulgham <bfulgham at webkit.org> has granted Patrick R. Gansterer
<paroga at paroga.com>'s request for review:
Bug 121599: [WIN] Replace CF time functions with Windows API functions in
WebHistory
https://bugs.webkit.org/show_bug.cgi?id=121599

Attachment 212439: Patch
https://bugs.webkit.org/attachment.cgi?id=212439&action=review

------- Additional Comments from Brent Fulgham <bfulgham at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=212439&action=review


Looks good to me, with some minor nits.

> Source/WebKit/win/WebHistory.cpp:100
> +    VariantTimeToSystemTime(day, &systemTime);

We have been prefixing these Windows API calls with :: (e.g.,
"::VariantTimeToSystemTime(...)" and "::SystemTimeToTzSpecificLocalTime(...)").


More information about the webkit-reviews mailing list