[webkit-reviews] review granted: [Bug 105662] CMakeChecker takes unusually long time to run : [Attachment 212595] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Sep 25 10:33:17 PDT 2013


Ryosuke Niwa <rniwa at webkit.org> has granted Patrick R. Gansterer
<paroga at paroga.com>'s request for review:
Bug 105662: CMakeChecker takes unusually long time to run
https://bugs.webkit.org/show_bug.cgi?id=105662

Attachment 212595: Patch
https://bugs.webkit.org/attachment.cgi?id=212595&action=review

------- Additional Comments from Ryosuke Niwa <rniwa at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=212595&action=review


> Tools/Scripts/webkitpy/style/checkers/common.py:46
> +    """Matches the string with the pattern, caching the compiled regexp."""

These comments are pretty useless.


More information about the webkit-reviews mailing list