[webkit-reviews] review granted: [Bug 119187] Inset box-shadows fail to round around corners when border-radius is set in vh/vw units. : [Attachment 212539] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Sep 25 09:39:12 PDT 2013


Darin Adler <darin at apple.com> has granted gur.trio at gmail.com's request for
review:
Bug 119187: Inset box-shadows fail to round around corners when border-radius
is set in vh/vw units.
https://bugs.webkit.org/show_bug.cgi?id=119187

Attachment 212539: Patch
https://bugs.webkit.org/attachment.cgi?id=212539&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=212539&action=review


> Source/WebCore/css/StyleResolver.h:314
> +    int viewportPercentageValue(CSSPrimitiveValue& unit, int percentage);
>      struct RuleRange {

Why is this grouped together with RuleRange? There should at least be a blank
line separating them.


More information about the webkit-reviews mailing list