[webkit-reviews] review requested: [Bug 106924] [GTK] GTK does not expose heading level correctly. Was: accessibility/heading-level.html is failing : [Attachment 212545] Patch proposal

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Sep 25 02:22:32 PDT 2013


Mario Sanchez Prada <mario at webkit.org> has asked  for review:
Bug 106924: [GTK] GTK does not expose heading level correctly. Was:
accessibility/heading-level.html is failing
https://bugs.webkit.org/show_bug.cgi?id=106924

Attachment 212545: Patch proposal
https://bugs.webkit.org/attachment.cgi?id=212545&action=review

------- Additional Comments from Mario Sanchez Prada <mario at webkit.org>
(In reply to comment #10)
> (From update of attachment 212466 [details])
> View in context:
https://bugs.webkit.org/attachment.cgi?id=212466&action=review
> 
> r- for some style considerations. thanks
> 
Sorry about those. It just a consequence of "expanding" the current function,
which contained the errors already and I did not realize about it.

Now attaching a new patch. I'll be also filing a new bug to normalize those
files so we don't use that anymore, to avoid issues/confusino when people
modify these files in the future.


More information about the webkit-reviews mailing list