[webkit-reviews] review denied: [Bug 112003] [EFL] accessibility/loading-iframe-sends-notification.html is failing : [Attachment 212541] Patch

[bugzilla-daemon at webkit.org]

Mario Sanchez Prada <mario at webkit.org> has denied Krzysztof Czech
<k.czech at samsung.com>'s request for review:
Bug 112003: [EFL] accessibility/loading-iframe-sends-notification.html is
failing
https://bugs.webkit.org/show_bug.cgi?id=112003

Attachment 212541: Patch
https://bugs.webkit.org/attachment.cgi?id=212541&action=review

------- Additional Comments from Mario Sanchez Prada <mario at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=212541&action=review


> Source/WebCore/dom/Document.cpp:2487
> +#if PLATFORM(MAC) || PLATFORM(WIN) || PLATFORM(GTK) || (PLATFORM(EFL) &&
HAVE(ACCESSIBILITY))

There are dummy implementations in AXObjectCache if !HAVE(ACCESSIBILITY), so
you do not need to add that condition there. Just adding "|| PLATFORM(EFL)"
should be enough

> Source/WebCore/page/FrameView.cpp:1328
> +#if PLATFORM(MAC) || PLATFORM(WIN) || PLATFORM(GTK) || (PLATFORM(EFL) &&
HAVE(ACCESSIBILITY))

Ditto.