[webkit-reviews] review granted: [Bug 121895] Remove the Windows-specific rules from WebKit2's DerivedSources.make, Windows is not supported anymore : [Attachment 212540] Patch

[bugzilla-daemon at webkit.org]

Alexey Proskuryakov <ap at webkit.org> has granted Sam Weinig <sam at webkit.org>'s
request for review:
Bug 121895: Remove the Windows-specific rules from WebKit2's
DerivedSources.make, Windows is not supported anymore
https://bugs.webkit.org/show_bug.cgi?id=121895

Attachment 212540: Patch
https://bugs.webkit.org/attachment.cgi?id=212540&action=review

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=212540&action=review


> Source/WebKit2/DerivedSources.make:1
> -# Copyright (C) 2010, 2011, 2012 Apple Inc. All rights reserved.
> +# Copyright (C) 2010, 2011, 2012, 2013 Apple Inc. All rights reserved.

Did we change this file this year? I don't think that removing code gives you
copyright.

> Source/WebKit2/DerivedSources.make:-139
> -# Mac-specific rules
> -
> -ifeq ($(PLATFORM_NAME),macosx)

These changes are not mentioned in ChangeLog, and surprised me.

Looks like this file is only used on Mac.