[webkit-reviews] review granted: [Bug 121880] More refactoring to make the LevelDB dependencies of IDB more obvious : [Attachment 212521] Patch v1

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Sep 24 16:47:05 PDT 2013


Alexey Proskuryakov <ap at webkit.org> has granted Brady Eidson
<beidson at apple.com>'s request for review:
Bug 121880: More refactoring to make the LevelDB dependencies of IDB more
obvious
https://bugs.webkit.org/show_bug.cgi?id=121880

Attachment 212521: Patch v1 
https://bugs.webkit.org/attachment.cgi?id=212521&action=review

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=212521&action=review


> Source/WebCore/ChangeLog:33
> +	   (WebCore::LevelDBFactory::~LevelDBFactory):
> +	   (WebCore::IDBBackingStore::createWeakPtr):
> +	   (WebCore::IDBBackingStore::RecordIdentifier::RecordIdentifier):
> +	   (WebCore::IDBBackingStore::RecordIdentifier::primaryKey):
> +	   (WebCore::IDBBackingStore::RecordIdentifier::version):
> +	   (WebCore::IDBBackingStore::RecordIdentifier::reset):
> +	   (WebCore::IDBBackingStore::Cursor::key):
> +	   (WebCore::IDBBackingStore::Cursor::primaryKey):
> +	   (WebCore::IDBBackingStore::Cursor::recordIdentifier):
> +	   (WebCore::IDBBackingStore::Cursor::~Cursor):
> +	   (WebCore::IDBBackingStore::Cursor::Cursor):
> +	   (WebCore::IDBBackingStore::Transaction::reset):
> +	   (WebCore::IDBBackingStore::Transaction::levelDBTransactionFrom):

Can you please remove all the function names? They are of no use whatsoever,
but waste space in svn log, buildbot console and such. And make reviewing
harder.


More information about the webkit-reviews mailing list