[webkit-reviews] review denied: [Bug 121808] Properly handle bottom margin on float with shape-outside : [Attachment 212400] Patch

[bugzilla-daemon at webkit.org]

Dave Hyatt <hyatt at apple.com> has denied Bem Jones-Bey <bjonesbe at adobe.com>'s
request for review:
Bug 121808: Properly handle bottom margin on float with shape-outside
https://bugs.webkit.org/show_bug.cgi?id=121808

Attachment 212400: Patch
https://bugs.webkit.org/attachment.cgi?id=212400&action=review

------- Additional Comments from Dave Hyatt <hyatt at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=212400&action=review


> Source/WebCore/rendering/RenderBlock.cpp:3754
> +	       floatBottom = r->y() + marginBeforeForChild(r->renderer()) +
shapeOutside->shapeLogicalBottom();

y() is wrong here. Let's get a vertical test, which will show why it's wrong.
:)