[webkit-reviews] review granted: [Bug 121840] Cache continuation() in a local to avoid repeat hash lookups. : [Attachment 212468] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Sep 24 08:37:53 PDT 2013


Geoffrey Garen <ggaren at apple.com> has granted Andreas Kling
<akling at apple.com>'s request for review:
Bug 121840: Cache continuation() in a local to avoid repeat hash lookups.
https://bugs.webkit.org/show_bug.cgi?id=121840

Attachment 212468: Patch
https://bugs.webkit.org/attachment.cgi?id=212468&action=review

------- Additional Comments from Geoffrey Garen <ggaren at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=212468&action=review


r=me, plz fix build -- see below

> Source/WebCore/rendering/RenderInline.cpp:1439
> +	       continuation->addFocusRingRects(rects,
flooredLayoutPoint(additionalOffset + toRenderBox(continuation())->location() -
containingBlock()->location()), paintContainer);

Nix the parens on 'continuation' here.


More information about the webkit-reviews mailing list