[webkit-reviews] review denied: [Bug 121674] [ATK] Missing WTR AccessibilityController::addNotificationListener implementation : [Attachment 212173] Patch

[bugzilla-daemon at webkit.org]

Mario Sanchez Prada <mario at webkit.org> has denied Denis Nomiyama (dnomi)
<d.nomiyama at samsung.com>'s request for review:
Bug 121674: [ATK] Missing WTR AccessibilityController::addNotificationListener
implementation
https://bugs.webkit.org/show_bug.cgi?id=121674

Attachment 212173: Patch
https://bugs.webkit.org/attachment.cgi?id=212173&action=review

------- Additional Comments from Mario Sanchez Prada <mario at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=212173&action=review


The patch is great, just r- because of the EFL bit, which I think it's better
to leave it to the EFL guys (so they can test it first)

> Tools/WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:100
> +#if !PLATFORM(GTK) && !PLATFORM(EFL) && !PLATFORM(MAC)

Unless you are sure about this working on EFL, I think it's probably better to
live the EFL check out of this patch and let the EFL guys (Krzysztof) know
about the change with a comment in bug 112003, where they track the issue about
the same failing test, buyt for EFL-WK2