[webkit-reviews] review granted: [Bug 120058] Add an MathMLSelectElement class to implement <maction> and <semantics> : [Attachment 212371] Patch V8

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Frédéric Wang <fred.wang at free.fr>'s
request for review:
Bug 120058: Add an MathMLSelectElement class to implement <maction> and
<semantics>
https://bugs.webkit.org/show_bug.cgi?id=120058

Attachment 212371: Patch V8
https://bugs.webkit.org/attachment.cgi?id=212371&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=212371&action=review


> Source/WebCore/mathml/MathMLSelectElement.cpp:56
> +    return (child->isElementNode() && child == m_selectedChild);

There is no need for the child->isElementNode() check. This line should read:

    return child == m_selectedChild;

No parentheses and no isElementNode check.

> Source/WebCore/mathml/MathMLSelectElement.cpp:107
> +    if (m_selectedChild && m_selectedChild->renderer())
> +	   Style::detachRenderTree(*m_selectedChild);

We will need to do the further research. Setting an object's style to "display:
none" results in the render object being destroyed, and I see no reason why
this change couldn't also do the same thing. Just requires some research to
figure out exactly how that works.