[webkit-reviews] review requested: [Bug 121792] [iOS] Initialize settings mediaPlayback{AllowsInline, RequiresUserGesture} and shouldRespectImageOrientation as appropriate : [Attachment 212410] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Sep 23 17:07:19 PDT 2013


Daniel Bates <dbates at webkit.org> has asked  for review:
Bug 121792: [iOS] Initialize settings mediaPlayback{AllowsInline,
RequiresUserGesture} and  shouldRespectImageOrientation as appropriate
https://bugs.webkit.org/show_bug.cgi?id=121792

Attachment 212410: Patch
https://bugs.webkit.org/attachment.cgi?id=212410&action=review

------- Additional Comments from Daniel Bates <dbates at webkit.org>
I've updated the patch to add constants whose definition is conditioned on
whether we are building for iOS instead of adding functions. I choose this to
approach to help make the code in Settings.cpp more readable by minimizing both
the number of added #ifdef guards and lines of code. Let me know if there is a
better way to define an iOS-specific default value for a setting.


More information about the webkit-reviews mailing list