[webkit-reviews] review granted: [Bug 121741] Web Inspector: show resource request initiator in the details sidebar : [Attachment 212263] Patch

[bugzilla-daemon at webkit.org]

Joseph Pecoraro <joepeck at webkit.org> has granted Timothy Hatcher
<timothy at apple.com>'s request for review:
Bug 121741: Web Inspector: show resource request initiator in the details
sidebar
https://bugs.webkit.org/show_bug.cgi?id=121741

Attachment 212263: Patch
https://bugs.webkit.org/attachment.cgi?id=212263&action=review

------- Additional Comments from Joseph Pecoraro <joepeck at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=212263&action=review


r=me

> Source/WebInspectorUI/UserInterface/FrameResourceManager.js:464
> +	       for (var i = 0; i < stackTracePayload.length; ++i) {
> +		   var callFramePayload = stackTracePayload[i];
> +		   if (!callFramePayload.url || callFramePayload.url ===
"[native code]")
> +		       continue;
> +
> +		   url = callFramePayload.url;
> +
> +		   // The lineNumber is 1-based, but we expect 0-based.
> +		   lineNumber = callFramePayload.lineNumber - 1;
> +
> +		   columnNumber = callFramePayload.columnNumber;

Do you want to "break;" here? I would expect that you would want to show the
latest stack frame info.