[webkit-reviews] review granted: [Bug 121794] Web Inspector: [CSS Regions] Display CSS Regions flow name in the inspector overlay : [Attachment 212364] Patch V1

[bugzilla-daemon at webkit.org]

Joseph Pecoraro <joepeck at webkit.org> has granted Alexandru Chiculita
<achicu at adobe.com>'s request for review:
Bug 121794: Web Inspector: [CSS Regions] Display CSS Regions flow name in the
inspector overlay
https://bugs.webkit.org/show_bug.cgi?id=121794

Attachment 212364: Patch V1
https://bugs.webkit.org/attachment.cgi?id=212364&action=review

------- Additional Comments from Joseph Pecoraro <joepeck at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=212364&action=review


> Source/WebCore/ChangeLog:12
> +	   This patch adds the "-webkit-flow-from" property in the inspector
overlay. The region
> +	   chain is already displayed with numbers, so it makes sense to have
the flow name around when
> +	   a CSS region is highlighted.

Nit: At some point we will drop the -webkit- vendor prefix. So including the
prefixed property name in the overlay could accidentally be overlooked and
become stale. I'd prefer a generic UI String like "Flow: ", or the non-prefixed
property in the callout. But I may be over thinking it.

> Source/WebCore/inspector/InspectorOverlayPage.html:41
> +  <span id="flow-name"><br /><span
class="css-property">-webkit-flow-from</span>: <span
id="flow-name-value"></span>;</span>

Style: Just "<br>" no need for "<br />".

> Source/WebCore/inspector/InspectorOverlayPage.js:270
> +    } else {
> +	   flowNameElement.style.display = "none";
> +    }

Style: No braces for single line if/else block.