[webkit-reviews] review granted: [Bug 121462] Introduce CSS_VALUE_TYPE_CASTS macro in order to cast CSSValue type : [Attachment 212329] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Gyuyoung Kim
<gyuyoung.kim at samsung.com>'s request for review:
Bug 121462: Introduce CSS_VALUE_TYPE_CASTS macro in order to cast CSSValue type
https://bugs.webkit.org/show_bug.cgi?id=121462

Attachment 212329: Patch
https://bugs.webkit.org/attachment.cgi?id=212329&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=212329&action=review


> Source/WebCore/ChangeLog:16
> +	   This patch support CSSImageSetValue and CSSREflectValue first. Other
CSS*Values
> +	   will use this macro step by step.

Typo: CSSReflectValue

> Source/WebCore/css/CSSValue.h:277
> +inline const CSS##ValueTypeName* toCSS##ValueTypeName(const CSSValue* value)
\
> +{ \
> +    ASSERT_WITH_SECURITY_IMPLICATION(!value || value->is##ValueTypeName());
\
> +    return static_cast<const CSS##ValueTypeName*>(value); \
> +} \
> +inline CSS##ValueTypeName* toCSS##ValueTypeName(CSSValue* value) \
> +{ \
> +    ASSERT_WITH_SECURITY_IMPLICATION(!value || value->is##ValueTypeName());
\
> +    return static_cast<CSS##ValueTypeName*>(value); \
> +} \

Why no versions that take references? Maybe we should have versions that take
RefPtr too?