[webkit-reviews] review granted: [Bug 121422] CSS Unit vh, vw, vmin and vmax in box-shadow are not applied. : [Attachment 212328] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted gur.trio at gmail.com's request for
review:
Bug 121422: CSS Unit vh, vw, vmin and vmax in box-shadow are not applied.
https://bugs.webkit.org/show_bug.cgi?id=121422

Attachment 212328: Patch
https://bugs.webkit.org/attachment.cgi?id=212328&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=212328&action=review


> Source/WebCore/css/StyleResolver.cpp:2400
> +	       if (item->x->isViewportPercentageLength())
> +		   x = viewportPercentageValue(*item->x.get(), x);
>	       int y = item->y->computeLength<int>(state.style(),
state.rootElementStyle(), zoomFactor);
> +	       if (item->y->isViewportPercentageLength())
> +		   y = viewportPercentageValue(*item->y.get(), y);
>	       int blur = item->blur ?
item->blur->computeLength<int>(state.style(), state.rootElementStyle(),
zoomFactor) : 0;
> +	       if (item->blur && item->blur->isViewportPercentageLength())
> +		   blur = viewportPercentageValue(*item->blur.get(), blur);
>	       int spread = item->spread ?
item->spread->computeLength<int>(state.style(), state.rootElementStyle(),
zoomFactor) : 0;
> +	       if (item->spread && item->spread->isViewportPercentageLength())
> +		   spread = viewportPercentageValue(*item->spread.get(),
spread);

No need to also use get() if we are using *.