[webkit-reviews] review granted: [Bug 120593] [Texmap] Reloading a webgl page doesn't work : [Attachment 211039] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Sep 23 08:08:49 PDT 2013


Noam Rosenthal <noam at webkit.org> has granted ChangSeok Oh
<changseok.oh at collabora.com>'s request for review:
Bug 120593: [Texmap] Reloading a webgl page doesn't work
https://bugs.webkit.org/show_bug.cgi?id=120593

Attachment 211039: Patch
https://bugs.webkit.org/attachment.cgi?id=211039&action=review

------- Additional Comments from Noam Rosenthal <noam at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=211039&action=review


> Source/WebCore/ChangeLog:14
> +	   m_contentLayer of GraphicsLayerTextureMapper could be a dangling
pointer while destroying
> +	   Document. GraphicsContextPrivate is destroyed before
GraphicsLayerTextureMapper.
> +	   So using its method such as setClient could be invalid in destructor
of
> +	   GraphicsLayerTextureMapper. I add platformLayerWillBeDestroyed to
TextureMapperPlatformLayer::Client
> +	   to let the client know that the m_contentLayer will be destroyed so
that the client make
> +	   its contentLayer set 0. With this way, we can avoid for
m_contentsLayer to be
> +	   a dangling pointer.

Change to:
Let GraphicsLayerTextureMapper know it needs to detach the platform layer when
a GraphicsContext3D is destroyed.


More information about the webkit-reviews mailing list