[webkit-reviews] review granted: [Bug 121703] [Autotools] Rework the build target selection : [Attachment 212209] Patch

[bugzilla-daemon at webkit.org]

Gustavo Noronha (kov) <gns at gnome.org> has granted Zan Dobersek
<zandobersek at gmail.com>'s request for review:
Bug 121703: [Autotools] Rework the build target selection
https://bugs.webkit.org/show_bug.cgi?id=121703

Attachment 212209: Patch
https://bugs.webkit.org/attachment.cgi?id=212209&action=review

------- Additional Comments from Gustavo Noronha (kov) <gns at gnome.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=212209&action=review


> Source/autotools/CustomMacros.m4:24
> +dnl AM_APPEND_TO_DESCRIPTION([DESCRIPTION], [STRING])
> +AC_DEFUN([AM_APPEND_TO_DESCRIPTION], [
> +  if test "$$1" != ""; then
> +    $1="${$1}, "
> +  fi
> +

Didn't we have something similar to this for the EGL/GLX/GLES2 stuff?

> Source/autotools/FindDependencies.m4:157
> -if test "$with_target" = "directfb"; then
> +if test "$enable_directdb_target" = "yes"; then
>      PKG_CHECK_MODULES(CAIRO, cairo-directfb >= cairo_required_version)
>      PKG_CHECK_MODULES(GTK, gtk+-directfb-2.0 >= $GTK_REQUIRED_VERSION)
>  else

This if/else should probably not be an else any longer, the directfb deps
should be an addition to the other ones, not an alternative. CAIRO_DIRECTFB and
GTK_DIRECTFB in order?

> ChangeLog:15
> +	   By default, the X11 target is enabled. This set is preserved only if
no --enable-*-target flag

This set? This default, maybe?