[webkit-reviews] review denied: [Bug 111986] [EFL] accessibility/aria-invalid is failing : [Attachment 212339] Patch

[bugzilla-daemon at webkit.org]

Mario Sanchez Prada <mario at webkit.org> has denied Krzysztof Czech
<k.czech at samsung.com>'s request for review:
Bug 111986: [EFL] accessibility/aria-invalid is failing
https://bugs.webkit.org/show_bug.cgi?id=111986

Attachment 212339: Patch
https://bugs.webkit.org/attachment.cgi?id=212339&action=review

------- Additional Comments from Mario Sanchez Prada <mario at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=212339&action=review


> Tools/DumpRenderTree/atk/AccessibilityCallbacksAtk.cpp:131
> +#elif PLATFORM(EFL) && HAVE(ACCESSIBILITY)

The whole content of this file is wrapper inside an HAVE(ACCESSIBILITY) guard,
so you don't need to add it explicitly here.

> Tools/DumpRenderTree/atk/AccessibilityCallbacksAtk.cpp:232
> +#elif PLATFORM(EFL) && HAVE(ACCESSIBILITY)

Same here

> Tools/DumpRenderTree/atk/AccessibilityCallbacksAtk.cpp:266
> +#elif PLATFORM(EFL) && HAVE(ACCESSIBILITY)

And here :)

>
Tools/WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.c
pp:116
> +#if PLATFORM(GTK) || (PLATFORM(EFL) && HAVE(ACCESSIBILITY))

In this case is different because this file is not guarded at all as the other
ones.

Perhaps we should do it here too? After all, this file does not make much sense
at all if you don't have accessibility enabled, does it? :)