[webkit-reviews] review denied: [Bug 121742] [GTK] Remove media/context-menu-actions.html from LayoutTests/platform/gtk-wk2/TestExpectations : [Attachment 212270] Patch

[bugzilla-daemon at webkit.org]

Mario Sanchez Prada <mario at webkit.org> has denied Anton Obzhirov
<a.obzhirov at samsung.com>'s request for review:
Bug 121742: [GTK] Remove media/context-menu-actions.html from
LayoutTests/platform/gtk-wk2/TestExpectations
https://bugs.webkit.org/show_bug.cgi?id=121742

Attachment 212270: Patch
https://bugs.webkit.org/attachment.cgi?id=212270&action=review

------- Additional Comments from Mario Sanchez Prada <mario at webkit.org>
This test is still failing in the WK2 bot (see [1]), so this gardening is not
correct.

However, it's worth mentioning that it's not crashing anymore, just timing out:


  01:39:37.250 26788 [180/386] media/context-menu-actions.html failed
unexpectedly (test timed out)
  01:39:37.250 26788 worker/0 killing driver
  01:39:37.251 26788 worker/0 media/context-menu-actions.html failed:


Curiously enough, I manually run it locally (against SVN r156267) to see if I
could reproduce the error and found that the test actually works, it just takes
too much time to sucessfully finish, for some reason.

Check what happens if I increase timeout up to 10 secs:

  $ time Tools/Scripts/run-webkit-tests --gtk -2 --time-out-ms=10000
media/context-menu-actions.html
  Using port 'gtk-wk2'
  Test configuration: <, x86, release>
  Placing test results in
/home/mario/work/WebKit/WebKitBuild/Release/layout-test-results
  Baseline search path: gtk-wk2 -> wk2 -> gtk -> generic
  Using Release build
  Pixel tests disabled
  Regular timeout: 10000, slow test timeout: 50000
  Command line:
/home/mario/work/WebKit/WebKitBuild/Release/Programs/WebKitTestRunner -

  Found 1 test; running 1, skipping 0.
  Running 1 WebKitTestRunner.	  

  The test ran as expected. 

  real	 0m5.114s
  user	 0m1.408s
  sys	 0m0.436s


And if I remove the --time-out-ms parameter:

  [...]
  [1/1] media/context-menu-actions.html failed unexpectedly (test timed out)

  Retrying 1 unexpected failure(s) ...

  Running 1 WebKitTestRunner.

  [1/1] media/context-menu-actions.html^C
  Interrupted, exiting ...
  Failed to execute Tools/Scripts/new-run-webkit-tests at
Tools/Scripts/run-webkit-tests line 100.

  real	0m7.021s
  user	0m1.352s
  sys	0m0.296s


Setting r- because of the explanation above.

[1]
http://build.webkit.org/builders/GTK%20Linux%2064-bit%20Release%20WK2%20%28Test
s%29/builds/8164/steps/layout-test/logs/stdio