[webkit-reviews] review granted: [Bug 121422] CSS Unit vh, vw, vmin and vmax in box-shadow are not applied. : [Attachment 212320] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Sun Sep 22 22:59:25 PDT 2013
Darin Adler <darin at apple.com> has granted gur.trio at gmail.com's request for
review:
Bug 121422: CSS Unit vh, vw, vmin and vmax in box-shadow are not applied.
https://bugs.webkit.org/show_bug.cgi?id=121422
Attachment 212320: Patch
https://bugs.webkit.org/attachment.cgi?id=212320&action=review
------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=212320&action=review
> Source/WebCore/css/StyleResolver.cpp:4068
> +int StyleResolver::viewportPercentageValue(CSSPrimitiveValue* unit, int
percentage)
The unit argument could be CSSPrimitiveValue& instead of CSSPrimitiveValue*.
> Source/WebCore/css/StyleResolver.h:588
> + // to get the viewport units value in terms of viewport height and width
This comment doesn’t seem to add much, and it’s also not in the right format.
We use sentence style comments, not fragments like this one. I suggest just
removing it.
More information about the webkit-reviews
mailing list