[webkit-reviews] review canceled: [Bug 121770] Add empty MainFrame class : [Attachment 212308] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Sun Sep 22 16:47:19 PDT 2013
Darin Adler <darin at apple.com> has canceled Darin Adler <darin at apple.com>'s
request for review:
Bug 121770: Add empty MainFrame class
https://bugs.webkit.org/show_bug.cgi?id=121770
Attachment 212308: Patch
https://bugs.webkit.org/attachment.cgi?id=212308&action=review
------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=212308&action=review
>> Source/WebCore/page/Page.cpp:145
>> + , m_mainFrame(MainFrame::create(*this,
*pageClients.loaderClientForMainFrame).get())
>
> What's with the .get() here?
Left over from when I was trying to use Ref here instead of RefPtr/PassRefPtr
for this never null pointer. Fixed in my next version.
More information about the webkit-reviews
mailing list