[webkit-reviews] review granted: [Bug 121768] CTTE: RenderNamedFlowThread and FlowThreadController should operate on Elements, not Nodes : [Attachment 212306] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Sep 22 14:16:22 PDT 2013


Andreas Kling <akling at apple.com> has granted Sam Weinig <sam at webkit.org>'s
request for review:
Bug 121768: CTTE: RenderNamedFlowThread and FlowThreadController should operate
on Elements, not Nodes
https://bugs.webkit.org/show_bug.cgi?id=121768

Attachment 212306: Patch
https://bugs.webkit.org/attachment.cgi?id=212306&action=review

------- Additional Comments from Andreas Kling <akling at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=212306&action=review


r=me

> Source/WebCore/rendering/RenderNamedFlowThread.cpp:556
> +static bool isContainedInElements(Vector<Element*> others, Element* element)


'others' should be a const reference, we are making a silly copy here.


More information about the webkit-reviews mailing list