[webkit-reviews] review granted: [Bug 121749] Move DFG inline caching logic into jit/ : [Attachment 212281] the patch

[bugzilla-daemon at webkit.org]

Sam Weinig <sam at webkit.org> has granted Filip Pizlo <fpizlo at apple.com>'s
request for review:
Bug 121749: Move DFG inline caching logic into jit/
https://bugs.webkit.org/show_bug.cgi?id=121749

Attachment 212281: the patch
https://bugs.webkit.org/attachment.cgi?id=212281&action=review

------- Additional Comments from Sam Weinig <sam at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=212281&action=review


> Source/JavaScriptCore/jit/JITCall.cpp:135
>  void JIT::compileCallEval(Instruction* instruction)
>  {
> +    
>      JITStubCall stubCall(this, cti_op_call_eval); // Initializes ScopeChain;
ReturnPC; CodeBlock.

You didn't mean to add this line.

> Source/JavaScriptCore/jit/Repatch.h:27
> +#define DFGRepatch_h

You should fix the header guard.