[webkit-reviews] review granted: [Bug 121750] Add ExecState::uncheckedArgument and use where possible to shrink a bit : [Attachment 212280] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Sep 21 13:02:47 PDT 2013


Andreas Kling <akling at apple.com> has granted Darin Adler <darin at apple.com>'s
request for review:
Bug 121750: Add ExecState::uncheckedArgument and use where possible to shrink a
bit
https://bugs.webkit.org/show_bug.cgi?id=121750

Attachment 212280: Patch
https://bugs.webkit.org/attachment.cgi?id=212280&action=review

------- Additional Comments from Andreas Kling <akling at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=212280&action=review


r=me buuuuut..

> Source/JavaScriptCore/interpreter/CallFrame.h:246
> +	   JSValue uncheckedArgument(size_t argument)

We should merge this with getArgumentUnsafe().

> Source/WebCore/bridge/objc/objc_instance.mm:269
> -	   for (unsigned i = 2; i < count ; i++) {
> +	   for (unsigned i = 2; i < count; i++) {

No switching to prefix increment style?


More information about the webkit-reviews mailing list