[webkit-reviews] review granted: [Bug 121751] Event and EventTarget interfaces don't need to be store as AtomicStrings : [Attachment 212279] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Sat Sep 21 12:59:13 PDT 2013
Andreas Kling <akling at apple.com> has granted Sam Weinig <sam at webkit.org>'s
request for review:
Bug 121751: Event and EventTarget interfaces don't need to be store as
AtomicStrings
https://bugs.webkit.org/show_bug.cgi?id=121751
Attachment 212279: Patch
https://bugs.webkit.org/attachment.cgi?id=212279&action=review
------- Additional Comments from Andreas Kling <akling at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=212279&action=review
r=me
> Source/WebCore/dom/EventNames.h:305
> + names.reserveCapacity(4);
> + names.append(touchstartEvent);
> + names.append(touchmoveEvent);
> + names.append(touchendEvent);
> + names.append(touchcancelEvent);
Since you are touching these lines, you might as well make it
reserveInitialCapacity() and uncheckedAppend().
More information about the webkit-reviews
mailing list