[webkit-reviews] review granted: [Bug 121711] Handle panning gestures messages properly on Windows : [Attachment 212245] patch

[bugzilla-daemon at webkit.org]

Brent Fulgham <bfulgham at webkit.org> has granted Roger Fong
<roger_fong at apple.com>'s request for review:
Bug 121711: Handle panning gestures messages properly on Windows
https://bugs.webkit.org/show_bug.cgi?id=121711

Attachment 212245: patch
https://bugs.webkit.org/attachment.cgi?id=212245&action=review

------- Additional Comments from Brent Fulgham <bfulgham at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=212245&action=review


Looks great!  We might want to add a FIXME for Right-to-left languages if
that's something we are likely to encounter for scroll bar support.

> Source/WebKit/win/WebView.cpp:1611
> +	       || (view->horizontalScrollbar() && (gestureBeginPoint.y >
(webViewRect.bottom -
view->horizontalScrollbar()->theme()->scrollbarThickness())));	

This might not be right for a right-to-left environment.

> Source/WebKit/win/WebView.cpp:1640
> +	   // Disable single-fingered horizontal panning only if the target
node text.

... target node *is* text?

> Source/WebKit/win/WebView.cpp:1741
> +	   UpdatePanningFeedbackPtr()(m_viewWindow, xpan, ypan, gi.dwFlags &
GF_INERTIA);

Nice!