[webkit-reviews] review granted: [Bug 121710] REGRESSION(r153215): New iCloud site crashes : [Attachment 212241] Patch

[bugzilla-daemon at webkit.org]

Filip Pizlo <fpizlo at apple.com> has granted Oliver Hunt <oliver at apple.com>'s
request for review:
Bug 121710: REGRESSION(r153215): New iCloud site crashes
https://bugs.webkit.org/show_bug.cgi?id=121710

Attachment 212241: Patch
https://bugs.webkit.org/attachment.cgi?id=212241&action=review

------- Additional Comments from Filip Pizlo <fpizlo at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=212241&action=review


r=me if you fix the test.

> LayoutTests/js/script-tests/dfg-arguments-mutated-structure.js:12
> +while(!dfgCompiled({f:foo}))
> +    foo();
> +
> +shouldBeTrue("foo()");

This is wrong.	You're forgetting to say noInline(foo).

The more canonical way to write a test like this is:

dfgShouldBe(foo, "foo()", "true");

dfgShouldBe() will automatically noInline and will automatically run enough
times.