[webkit-reviews] review granted: [Bug 121723] Web Inspector: Format JSON for request just like responses : [Attachment 212231] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Sep 20 16:22:13 PDT 2013


Joseph Pecoraro <joepeck at webkit.org> has granted Timothy Hatcher
<timothy at apple.com>'s request for review:
Bug 121723: Web Inspector: Format JSON for request just like responses
https://bugs.webkit.org/show_bug.cgi?id=121723

Attachment 212231: Patch
https://bugs.webkit.org/attachment.cgi?id=212231&action=review

------- Additional Comments from Joseph Pecoraro <joepeck at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=212231&action=review


Nice! r=me

> Source/WebInspectorUI/UserInterface/Utilities.js:1146
> +	   if (subparts[0].toLowerCase() === "boundary")
> +	       boundary = subparts[1];
> +	   else if (subparts[0].toLowerCase() === "charset")

Nit: Avoid duplicate toLowerCase()?


More information about the webkit-reviews mailing list