[webkit-reviews] review granted: [Bug 121705] WebKit should build against the Xcode default toolchain when targeting OS X 10.8 : [Attachment 212210] Patch v2

[bugzilla-daemon at webkit.org]

mitz at webkit.org <mitz at webkit.org> has granted Mark Rowe (bdash)
<mrowe at apple.com>'s request for review:
Bug 121705: WebKit should build against the Xcode default toolchain when
targeting OS X 10.8
https://bugs.webkit.org/show_bug.cgi?id=121705

Attachment 212210: Patch v2
https://bugs.webkit.org/attachment.cgi?id=212210&action=review

------- Additional Comments from mitz at webkit.org <mitz at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=212210&action=review


r=me

> Source/JavaScriptCore/Configurations/Base.xcconfig:131
> +TOOLCHAINS_iphonesimulator = $(TOOLCHAINS);

I think we normally do something like
TOOLCHAINS_iphonesimulator = $(TOOLCHAINS_iphoneos);
but I’m not sure if there’s a good reason to do so here.