[webkit-reviews] review granted: [Bug 121692] Move layer hierarchy functions from RenderObject to RenderElement : [Attachment 212202] remember to call base class versions of virtual functions
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Sep 20 12:45:11 PDT 2013
Andreas Kling <akling at apple.com> has granted Antti Koivisto <koivisto at iki.fi>'s
request for review:
Bug 121692: Move layer hierarchy functions from RenderObject to RenderElement
https://bugs.webkit.org/show_bug.cgi?id=121692
Attachment 212202: remember to call base class versions of virtual functions
https://bugs.webkit.org/attachment.cgi?id=212202&action=review
------- Additional Comments from Andreas Kling <akling at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=212202&action=review
r=me
> Source/WebCore/rendering/RenderElement.cpp:203
> + newObject = 0;
nullptr
> Source/WebCore/rendering/RenderElement.cpp:263
> + return 0;
nullptr
> Source/WebCore/rendering/RenderElement.cpp:315
> + RenderLayer* layer = 0;
nullptr
> Source/WebCore/rendering/RenderElement.cpp:334
> + RenderLayer* layer = 0;
nullptr
> Source/WebCore/rendering/RenderElement.cpp:336
> + if ((layer = parent()->enclosingLayer()))
Extra () pair here.
More information about the webkit-reviews
mailing list