[webkit-reviews] review granted: [Bug 121633] [GTK] Clean up the Skip* functions in the GObject DOM bindings code generator : [Attachment 212104] Patch

[bugzilla-daemon at webkit.org]

Gustavo Noronha (kov) <gns at gnome.org> has granted Martin Robinson
<mrobinson at webkit.org>'s request for review:
Bug 121633: [GTK] Clean up the Skip* functions in the GObject DOM bindings code
generator
https://bugs.webkit.org/show_bug.cgi?id=121633

Attachment 212104: Patch
https://bugs.webkit.org/attachment.cgi?id=212104&action=review

------- Additional Comments from Gustavo Noronha (kov) <gns at gnome.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=212104&action=review


> Source/WebCore/bindings/scripts/CodeGeneratorGObject.pm:-247
> -

nit: does this improve readability in your opinion?

> Source/WebCore/bindings/scripts/CodeGeneratorGObject.pm:-907
> -	   if ($paramIDLType eq "EventListener" || $paramIDLType eq
"MediaQueryListListener") {
> -	       # EventListeners are handled elsewhere.
> -	       return;
> -	   }

Where are these skipped in this for loop? Or do they not even get here in the
function->parameters?