[webkit-reviews] review requested: [Bug 85994] [GStreamer] Source element fails with .ogg files : [Attachment 212178] Patch to handle 200 response on HTTP range requests

[bugzilla-daemon at webkit.org]

Andre Moreira Magalhaes <andrunko at gmail.com> has asked	for review:
Bug 85994: [GStreamer] Source element fails with .ogg files
https://bugs.webkit.org/show_bug.cgi?id=85994

Attachment 212178: Patch to handle 200 response on HTTP range requests
https://bugs.webkit.org/attachment.cgi?id=212178&action=review

------- Additional Comments from Andre Moreira Magalhaes <andrunko at gmail.com>
(In reply to comment #34)
> (From update of attachment 212174 [details])
> View in context:
https://bugs.webkit.org/attachment.cgi?id=212174&action=review
> 
> >
Source/WebCore/platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:-924
> > -	     locker.unlock();
> 
> Why remove this?

Oops, missed this one, fixed.

Btw, all the seeks that happen when loading this page are requested by oggdemux
when trying to determine the stream duration. oggdemux will try to seek near
the end of the file and then seek back to pos=1 (skip header) to determine the
duration. Maybe we could find a way to cache the already downloaded resources
and reuse them instead of re-requesting the data to the server (and getting the
whole data again) on every seek.