[webkit-reviews] review granted: [Bug 121451] AX: Expose ARIA Busy Notifications : [Attachment 212009] Updated patch.

[bugzilla-daemon at webkit.org]

chris fleizach <cfleizach at apple.com> has granted Samuel White
<samuel_white at apple.com>'s request for review:
Bug 121451: AX: Expose ARIA Busy Notifications
https://bugs.webkit.org/show_bug.cgi?id=121451

Attachment 212009: Updated patch.
https://bugs.webkit.org/attachment.cgi?id=212009&action=review

------- Additional Comments from chris fleizach <cfleizach at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=212009&action=review


> LayoutTests/platform/mac/accessibility/element-busy-changed.html:27
> +		   shouldBe("elementBusyChangedCount", "2");

This seems like a gratuitous shouldBe() since the if statement already does
this.

I propose you just use a debug log to output that you received the notification
(instead of a shouldBe)

debug("Received: " + notification)

that way if the test fails, we'll see in the diff right away that oh, we're
missing one of those notifications