[webkit-reviews] review granted: [Bug 121676] Add valueForLength/minimumValueForLength wrappers to RenderObject. : [Attachment 212157] Patch idea

[bugzilla-daemon at webkit.org]

Antti Koivisto <koivisto at iki.fi> has granted Andreas Kling <akling at apple.com>'s
request for review:
Bug 121676: Add valueForLength/minimumValueForLength wrappers to RenderObject.
https://bugs.webkit.org/show_bug.cgi?id=121676

Attachment 212157: Patch idea
https://bugs.webkit.org/attachment.cgi?id=212157&action=review

------- Additional Comments from Antti Koivisto <koivisto at iki.fi>
View in context: https://bugs.webkit.org/attachment.cgi?id=212157&action=review


> Source/WebCore/rendering/RenderObject.h:1003
> +    LayoutUnit valueForLength(const Length& length, LayoutUnit maximumValue,
bool roundPercentages = false) const
> +    {
> +	   return WebCore::valueForLength(length, maximumValue, &view(),
roundPercentages);
> +    }
> +
> +    LayoutUnit minimumValueForLength(const Length& length, LayoutUnit
maximumValue, bool roundPercentages = false) const
> +    {
> +	   return WebCore::minimumValueForLength(length, maximumValue, &view(),
roundPercentages);
> +    }

RenderText should not have any valid uses for these. Please move to
RenderElement.